Skip to content

Conversation

Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Jul 7, 2025

Summary of changes:

  1. Updated Intel MKL version from 2025.0.0 to 2025.2.0 in bazel.
  2. Added support for downloading and unpacking required MKL libraries from .conda archives (used in C++, without involving Python).
  3. Fixed a minor typo in Bazel function name: substitudesubstitute.
  4. Switched MKL linkage from static (.a) to dynamic (.so) across for SYCL components.

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Vika-F Vika-F requested a review from Copilot July 17, 2025 08:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Bazel integration to use dynamic MKL libraries at version 2025.2.0, adds support for extracting .conda archives, and fixes a typo in the utility function name.

  • Bump Intel MKL version from 2025.0.0 to 2025.2.0 and switch linkage to shared .so libraries
  • Introduce .conda archive download and extraction in _download_and_extract
  • Rename _substitude_substitute and update references

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
dev/bazel/utils.bzl Renamed typo in substitution helper (substitudesubstitute)
dev/bazel/repos.bzl Added logic to download and unpack .conda archives
dev/bazel/deps/onedal.tpl.BUILD Added @mkl//:mkl_thr to onedal dependencies
dev/bazel/deps/mkl.tpl.BUILD Replaced static .a libs with shared .so and added mkl_dpc_utils
dev/bazel/deps/mkl.bzl Updated libs list to reference .so files; removed mapping comment
MODULE.bazel Updated MKL URLs, checksums, and strip_prefixes for 2025.2.0
Comments suppressed due to low confidence (2)

dev/bazel/repos.bzl:31

  • New extraction logic for '.conda' archives is introduced without tests; consider adding unit tests to verify this code path.
    if filename.endswith(".conda"):

dev/bazel/repos.bzl:38

  • String interpolation uses Path objects directly; convert 'entry' and 'output' to string paths (e.g., entry.path, output.path) to ensure the command runs correctly.
                repo_ctx.execute(["bash", "-c", "unzstd '%s' --stdout | tar -xf - -C '%s'" % (entry, output)])

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev Alexandr-Solovev merged commit e19dbc4 into uxlfoundation:main Aug 20, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants