-
Notifications
You must be signed in to change notification settings - Fork 117
[oneDPL][rfc][ranges][L1] the third portion of the range based API #2269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an RFC for the third portion of oneDPL range-based APIs, focusing on implementing additional parallel algorithms based on usage statistics from GitHub C++ code analysis. The proposal outlines the implementation approach, requirements, and testing strategy for these new range-based algorithm variants.
- Proposes 14 new range-based algorithms including set operations, memory algorithms, and mutating algorithms
- Establishes implementation requirements based on P3179 and P3709 proposals with support for all oneDPL execution policies
- Defines comprehensive testing coverage requirements and implementation limitations for device policies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optional wording change, but LGTM.
Largely this is similar to previous RFCs.
I wonder if it makes sense to extract some shared language between these in an umbrella RFC and have individual pieces reference that. Not sure if its worth the effort.
Co-authored-by: Dan Hoeflinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapproving
@danhoeflinger, sorry for dismissing your approval. I've added one more correction. I do not plan adding more.
That's because in order to test the memory algorithms, you need to manually manage memory. The views removed, such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will reapprove if you apply my nitpick.
Co-authored-by: Dan Hoeflinger <[email protected]>
60ebce0
[oneDPL][rfc][ranges][L1] the third portion of the range based API