[enhancement] WIP: move finite check to sklearnex in ensemble algos #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icfaust/scikit-learn-intelex into dev/sklearnex_assert_all_finite
13 tasks
Merged
7 tasks
|
|
||
| class DummyEstimator(BaseEstimator): | ||
|
|
||
| def fit(self, X, y=None): |
There was a problem hiding this comment.
This looks like an accidental change.
| multi_output=True, | ||
| accept_sparse=False, | ||
| dtype=[np.float64, np.float32], | ||
| dtype=[xp.float64, xp.float32], |
There was a problem hiding this comment.
Shouldn't the call to get this 'xp' pass all of the data arrays? (X+y+sample_weight)
|
|
||
| def _estimators_(self): | ||
| """This attribute provides lazy creation of scikit-learn conformant | ||
| Decision Trees used for analysis in such as 'apply'. This will stay |
There was a problem hiding this comment.
Suggested change
| Decision Trees used for analysis in such as 'apply'. This will stay | |
| Decision Trees used for analysis in methods such as 'apply'. This will stay |
| ), | ||
| ] | ||
| ) | ||
| # TODO: Fix to support integers as input |
There was a problem hiding this comment.
Would this be implemented with the changes in this PR?
There was a problem hiding this comment.
Not sure yet. we will see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temp
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance