-
Notifications
You must be signed in to change notification settings - Fork 183
[enhancement] WIP: move finite check to sklearnex in ensemble algos #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…icfaust/scikit-learn-intelex into dev/sklearnex_assert_all_finite
|
||
class DummyEstimator(BaseEstimator): | ||
|
||
def fit(self, X, y=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an accidental change.
multi_output=True, | ||
accept_sparse=False, | ||
dtype=[np.float64, np.float32], | ||
dtype=[xp.float64, xp.float32], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the call to get this 'xp' pass all of the data arrays? (X+y+sample_weight)
|
||
def _estimators_(self): | ||
"""This attribute provides lazy creation of scikit-learn conformant | ||
Decision Trees used for analysis in such as 'apply'. This will stay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision Trees used for analysis in such as 'apply'. This will stay | |
Decision Trees used for analysis in methods such as 'apply'. This will stay |
), | ||
] | ||
) | ||
# TODO: Fix to support integers as input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be implemented with the changes in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet. we will see.
Description
Temp
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance