Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
215 commits
Select commit Hold shift + click to select a range
32fe269
add finiteness_checker pybind11 bindings
icfaust Oct 23, 2024
cdbf1b5
added finiteness checker
icfaust Oct 23, 2024
62674a2
Update finiteness_checker.cpp
icfaust Oct 23, 2024
c75c23b
Update finiteness_checker.cpp
icfaust Oct 23, 2024
6a20938
Update finiteness_checker.cpp
icfaust Oct 23, 2024
382d7a1
Update finiteness_checker.cpp
icfaust Oct 23, 2024
c8ffd9c
Update finiteness_checker.cpp
icfaust Oct 23, 2024
9aa13d5
Update finiteness_checker.cpp
icfaust Oct 23, 2024
84e15d5
Rename finiteness_checker.cpp to finiteness_checker.cpp
icfaust Oct 23, 2024
63073c6
Update finiteness_checker.cpp
icfaust Oct 24, 2024
d915da5
Merge branch 'intel:main' into dev/new_assert_all_fininte
icfaust Oct 28, 2024
3dddf2d
add next step
icfaust Oct 31, 2024
1e1213e
follow conventions
icfaust Oct 31, 2024
0531713
make xtable explicit
icfaust Oct 31, 2024
e831167
remove comment
icfaust Oct 31, 2024
d6eb1d0
Update validation.py
icfaust Oct 31, 2024
fb30d6e
Update __init__.py
icfaust Nov 1, 2024
63a18c2
Update validation.py
icfaust Nov 1, 2024
76c0856
Update __init__.py
icfaust Nov 1, 2024
7deb2bb
Update __init__.py
icfaust Nov 1, 2024
ed46b29
Update validation.py
icfaust Nov 1, 2024
67d6273
Update _data_conversion.py
icfaust Nov 1, 2024
054f0a1
Merge branch 'main' into dev/new_assert_all_fininte
icfaust Nov 1, 2024
8abead9
Update _data_conversion.py
icfaust Nov 1, 2024
47d0f8b
Update policy_common.cpp
icfaust Nov 1, 2024
e48c2bd
Update policy_common.cpp
icfaust Nov 1, 2024
c6751c4
Update _policy.py
icfaust Nov 1, 2024
f3e4a3a
Update policy_common.cpp
icfaust Nov 2, 2024
39cdb5f
Rename finiteness_checker.cpp to finiteness_checker.cpp
icfaust Nov 2, 2024
0f39613
Create finiteness_checker.py
icfaust Nov 2, 2024
b42cfe3
Update validation.py
icfaust Nov 2, 2024
0ed615e
Update __init__.py
icfaust Nov 2, 2024
f101aff
attempt at fixing circular imports again
icfaust Nov 2, 2024
24c0e94
fix isort
icfaust Nov 2, 2024
3f96166
remove __init__ changes
icfaust Nov 2, 2024
d985053
last move
icfaust Nov 2, 2024
90ec48b
Update policy_common.cpp
icfaust Nov 2, 2024
8c2c854
Update policy_common.cpp
icfaust Nov 2, 2024
6fa38d7
Update policy_common.cpp
icfaust Nov 2, 2024
9c1ca9c
Update policy_common.cpp
icfaust Nov 2, 2024
4b67dbd
Update validation.py
icfaust Nov 2, 2024
fa59a3c
add testing
icfaust Nov 2, 2024
3330b33
isort
icfaust Nov 2, 2024
4895940
attempt to fix module error
icfaust Nov 2, 2024
0c6dd5d
add fptype
icfaust Nov 2, 2024
e2182fa
fix typo
icfaust Nov 2, 2024
982ef2c
Update validation.py
icfaust Nov 2, 2024
2fb52a8
remove sua_ifcae from to_table
icfaust Nov 3, 2024
28dc267
isort and black
icfaust Nov 3, 2024
2f85fd4
Update test_memory_usage.py
icfaust Nov 3, 2024
8659248
format
icfaust Nov 3, 2024
3827d6f
Update _data_conversion.py
icfaust Nov 3, 2024
55fa7d2
Update _data_conversion.py
icfaust Nov 3, 2024
175cd78
Update test_validation.py
icfaust Nov 3, 2024
7016ad0
remove unnecessary code
icfaust Nov 3, 2024
1a01859
Merge branch 'main' into dev/new_assert_all_fininte
icfaust Nov 18, 2024
2fbcdd9
merge master
icfaust Nov 18, 2024
fb7375f
make reviewer changes
icfaust Nov 19, 2024
30816bf
make dtype check change
icfaust Nov 19, 2024
abb3b16
add sparse testing
icfaust Nov 19, 2024
97aef73
try again
icfaust Nov 19, 2024
6e29651
try again
icfaust Nov 19, 2024
59363a8
try again
icfaust Nov 19, 2024
12de703
temporary commit
icfaust Nov 20, 2024
07ec3d8
first attempt
icfaust Nov 20, 2024
32c565d
missing change?
icfaust Nov 20, 2024
a571a4e
Merge branch 'intel:main' into dev/sklearnex_assert_all_finite
icfaust Nov 20, 2024
5093ed7
modify DummyEstimator for testing
icfaust Nov 20, 2024
f04deba
generalize DummyEstimator
icfaust Nov 20, 2024
740a5e7
switch test
icfaust Nov 20, 2024
27050bd
further testing changes
icfaust Nov 20, 2024
53c8f7b
add initial validate_data test, will be refactored
icfaust Nov 20, 2024
90f59c4
fixes for CI
icfaust Nov 20, 2024
7f170e2
Update validation.py
icfaust Nov 20, 2024
81e2bbc
Update validation.py
icfaust Nov 20, 2024
116bdba
Update test_memory_usage.py
icfaust Nov 20, 2024
076ebc4
Update base.py
icfaust Nov 20, 2024
e1d0743
Update base.py
icfaust Nov 20, 2024
f59cdd3
improve tests
icfaust Nov 20, 2024
7f9ea25
fix logic
icfaust Nov 20, 2024
51247c0
fix logic
icfaust Nov 20, 2024
6e5c0ef
fix logic again
icfaust Nov 20, 2024
8d47744
rename file
icfaust Nov 20, 2024
1ae9af5
Revert "rename file"
icfaust Nov 20, 2024
bf9b46e
remove duplication
icfaust Nov 20, 2024
3101c3f
fix imports
icfaust Nov 20, 2024
6da176b
Merge branch 'intel:main' into dev/sklearnex_assert_all_finite
icfaust Nov 20, 2024
ee799f6
Rename test_finite.py to test_validation.py
icfaust Nov 20, 2024
db4a6c6
Revert "Rename test_finite.py to test_validation.py"
icfaust Nov 20, 2024
b5acbac
updates
icfaust Nov 21, 2024
ed57c15
Update validation.py
icfaust Nov 21, 2024
414f897
fixes for some test failures
icfaust Nov 21, 2024
83253b3
fix text
icfaust Nov 21, 2024
b22e23a
fixes for some failures
icfaust Nov 21, 2024
2f8ec16
make consistent
icfaust Nov 21, 2024
1fd9973
fix bad logic
icfaust Nov 21, 2024
c20c8cc
fix in string
icfaust Nov 21, 2024
1ce1b10
attempt tp see if dataframe conversion is causing the issue
icfaust Nov 21, 2024
5355039
fix iter problem
icfaust Nov 21, 2024
b5b8442
fix testing issues
icfaust Nov 21, 2024
d025c89
formatting
icfaust Nov 21, 2024
428bfb6
revert change
icfaust Nov 21, 2024
da23138
fixes for pandas
icfaust Nov 21, 2024
1d0c330
there is a slowdown with pandas that needs to be solved
icfaust Nov 21, 2024
f3f63a6
swap to transpose for speed
icfaust Nov 21, 2024
56c8054
more clarity
icfaust Nov 21, 2024
1580d77
add _check_sample_weight
icfaust Nov 22, 2024
ffc9f1f
add more testing'
icfaust Nov 22, 2024
d184ed0
rename
icfaust Nov 22, 2024
c68616f
remove unnecessary imports
icfaust Nov 22, 2024
e7ea94e
fix test slowness
icfaust Nov 22, 2024
dbe108d
focus get_dataframes_and_queues
icfaust Nov 22, 2024
7284b59
put config_context around
icfaust Nov 22, 2024
e1be91d
Update test_validation.py
icfaust Nov 24, 2024
8a0f9e9
Update base.py
icfaust Nov 24, 2024
5272207
Update test_validation.py
icfaust Nov 24, 2024
21a7896
Merge branch 'intel:main' into dev/sklearnex_assert_all_finite
icfaust Nov 24, 2024
56b5c4c
generalize regex
icfaust Nov 25, 2024
0d1b306
add fixes for sklearn 1.0 and input_name
icfaust Nov 25, 2024
8ff312e
fixes for test failures
icfaust Nov 25, 2024
87b7e3b
Update validation.py
icfaust Nov 25, 2024
29e8f8c
Update test_validation.py
icfaust Nov 25, 2024
527ce22
Merge branch 'intel:main' into dev/sklearnex_assert_all_finite
icfaust Nov 25, 2024
27ce5fc
Update validation.py
icfaust Nov 27, 2024
5d31988
formattintg
icfaust Nov 27, 2024
c4dccd6
make suggested changes
icfaust Nov 27, 2024
f83f1ef
follow changes made in #2126
icfaust Nov 27, 2024
0356a90
Merge branch 'intel:main' into dev/sklearnex_assert_all_finite
icfaust Nov 27, 2024
e43c047
fix future device problem
icfaust Nov 27, 2024
a9504a8
Merge branch 'dev/sklearnex_assert_all_finite' of https://github.com/…
icfaust Nov 27, 2024
b799d44
Merge branch 'intel:main' into dev/sklearnex_assert_all_finite
icfaust Nov 27, 2024
5c81f9d
Update validation.py
icfaust Nov 27, 2024
6ef96b1
merge main
icfaust Nov 28, 2024
1db7575
Merge branch 'uxlfoundation:main' into dev/sklearnex_assert_all_finite
icfaust Dec 2, 2024
38d0079
finished movement
icfaust Dec 2, 2024
bde3f3b
fix first error
icfaust Dec 2, 2024
ebf1ac4
next mistake
icfaust Dec 2, 2024
c2e5757
remove bad dtypes check
icfaust Dec 2, 2024
f8900e3
Merge branch 'main' into dev/new_RF
icfaust Sep 18, 2025
dc59785
Merge branch 'main' into dev/new_RF
icfaust Oct 20, 2025
368da05
updates
icfaust Oct 20, 2025
f3d2ec0
remove array
icfaust Oct 20, 2025
dd0001a
solve onedal issues
icfaust Oct 20, 2025
8ab87c8
solve onedal issues
icfaust Oct 20, 2025
d25ba9f
updates
icfaust Oct 20, 2025
90a7459
updates
icfaust Oct 21, 2025
7d9137a
further fixes
icfaust Oct 21, 2025
4ddf8e8
further fixes
icfaust Oct 21, 2025
f19a240
fix issues to see how it goes
icfaust Oct 21, 2025
9b16acf
oops
icfaust Oct 21, 2025
9e5a5ad
updates
icfaust Oct 21, 2025
37cbfe8
add finite checks for predict and predict_proba
icfaust Oct 21, 2025
9cfa09c
updates
icfaust Oct 21, 2025
72018df
centralize
icfaust Oct 21, 2025
8398084
further reduce code
icfaust Oct 21, 2025
3ca3dfe
updates
icfaust Oct 21, 2025
2ac5689
remove sklearn conformance from onedal estimator init signature
icfaust Oct 21, 2025
ac656cd
remove more
icfaust Oct 21, 2025
a97a260
fixes
icfaust Oct 21, 2025
9ae2b72
change away from sklearn `max_samples` in onedal estimators
icfaust Oct 21, 2025
3a14e98
fix error
icfaust Oct 21, 2025
d30b867
move things
icfaust Oct 21, 2025
a502efe
Update forest.py
icfaust Oct 22, 2025
134dc23
Update forest.py
icfaust Oct 22, 2025
c70720c
Update _forest.py
icfaust Oct 22, 2025
3d29655
further fixes to onedal side
icfaust Oct 22, 2025
79f1778
further fixes to onedal side
icfaust Oct 22, 2025
c9e8f18
simplifications
icfaust Oct 22, 2025
3748404
attempt at classifiers support
icfaust Oct 22, 2025
1ec4fd0
further changes
icfaust Oct 22, 2025
a9b07ae
fix error on onedal side
icfaust Oct 22, 2025
d8543cb
fix error on onedal side
icfaust Oct 22, 2025
deef027
fixes
icfaust Oct 22, 2025
0367ecc
fix pandas related error
icfaust Oct 22, 2025
4519386
remove unnecessary code:
icfaust Oct 22, 2025
3aae224
try to fix issues related to regressor data
icfaust Oct 22, 2025
349eb1f
fixes necessary for CI
icfaust Oct 22, 2025
af4089c
fixes for formatting
icfaust Oct 22, 2025
358feda
updates
icfaust Oct 22, 2025
82e97f4
push
icfaust Oct 22, 2025
2963662
push
icfaust Oct 22, 2025
2900624
fixes
icfaust Oct 22, 2025
5736ecb
remove upon request
icfaust Oct 22, 2025
df3b316
remove upon request
icfaust Oct 22, 2025
a541419
further fixes
icfaust Oct 22, 2025
0c22a76
try to fix classifiers for array API inputs
icfaust Oct 22, 2025
c343239
try again
icfaust Oct 22, 2025
dddf2f3
Update array_api.rst
icfaust Oct 22, 2025
6dd1d20
Update sklearnex/ensemble/_forest.py
icfaust Oct 22, 2025
71a30e9
Update _forest.py
icfaust Oct 23, 2025
afd0f3a
Update _forest.py
icfaust Oct 23, 2025
1ce8f81
Update _forest.py
icfaust Oct 23, 2025
5d84beb
Merge branch 'uxlfoundation:main' into dev/new_RF
icfaust Oct 23, 2025
665b903
Update _forest.py
icfaust Oct 23, 2025
ff5d5cf
Merge branch 'uxlfoundation:main' into dev/new_RF
icfaust Oct 24, 2025
c04dd35
Merge branch 'uxlfoundation:main' into dev/new_RF
icfaust Nov 12, 2025
61fa425
Update _forest.py
icfaust Nov 26, 2025
2ba6027
Update _forest.py
icfaust Nov 26, 2025
e885a1f
Update _forest.py
icfaust Nov 26, 2025
ccb2845
Update _forest.py
icfaust Nov 27, 2025
25b8014
Update _forest.py
icfaust Nov 27, 2025
65eaf1e
Update _forest.py
icfaust Nov 27, 2025
2f991d2
Update forest.py
icfaust Nov 27, 2025
aee12e4
Update _forest.py
icfaust Nov 27, 2025
3ee6ab5
Merge branch 'uxlfoundation:main' into dev/new_RF
icfaust Dec 2, 2025
ae13966
Update sklearnex/ensemble/_forest.py
icfaust Dec 4, 2025
a9e5324
Update _forest.py
icfaust Dec 4, 2025
86bf80a
Update _forest.py
icfaust Dec 5, 2025
6a83091
Update array_api.rst
icfaust Dec 5, 2025
7c439be
Update array_api.rst
icfaust Dec 5, 2025
fc77422
remove sparse checks for sample_weight
icfaust Dec 6, 2025
772fe68
Merge branch 'uxlfoundation:main' into dev/new_RF
icfaust Dec 6, 2025
e1ad668
Update deselected_tests.yaml
icfaust Dec 6, 2025
3922290
Update deselected_tests.yaml
icfaust Dec 7, 2025
3b6f8de
Merge branch 'uxlfoundation:main' into dev/new_RF
icfaust Dec 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions deselected_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -525,12 +525,8 @@ gpu:
- tests/test_common.py::test_estimators[ExtraTreesClassifier()-check_class_weight_classifiers]
- tests/test_common.py::test_estimators[ExtraTreesRegressor()-check_sample_weights_invariance(kind=zeros)]
- tests/test_common.py::test_estimators[RandomForestRegressor()-check_regressor_data_not_an_array]

# GPU implementation of Extra Trees doesn't support sample_weights
# comparisons to GPU with sample weights will use different algorithms
- tests/test_common.py::test_estimators[ExtraTreesClassifier()-check_sample_weights_invariance(kind=ones)]
- tests/test_common.py::test_estimators[ExtraTreesClassifier()-check_sample_weights_invariance(kind=zeros)]
- tests/test_common.py::test_estimators[ExtraTreesRegressor()-check_sample_weights_invariance(kind=ones)]
- ensemble/tests/test_forest.py::test_min_weight_fraction_leaf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @Alexandr-Solovev - this test in particular is very straighforward and not expected to fail, yet it does here.


# RuntimeError: Device support is not implemented, failing as result of fallback to cpu false
- svm/tests/test_svm.py::test_unfitted
Expand Down
9 changes: 9 additions & 0 deletions doc/sources/array_api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ The following patched classes have support for array API inputs:
- :obj:`sklearn.covariance.EmpiricalCovariance`
- :obj:`sklearnex.covariance.IncrementalEmpiricalCovariance`
- :obj:`sklearn.decomposition.PCA`
- :obj:`sklearn.ensemble.ExtraTreesClassifier`
- :obj:`sklearn.ensemble.ExtraTreesRegressor`
- :obj:`sklearn.ensemble.RandomForestClassifier`
- :obj:`sklearn.ensemble.RandomForestRegressor`
- :obj:`sklearn.linear_model.LinearRegression`
- :obj:`sklearn.linear_model.Ridge`
- :obj:`sklearnex.linear_model.IncrementalLinearRegression`
Expand All @@ -108,6 +112,11 @@ The following patched classes have support for array API inputs:
enabled in |sklearn|, when passing these classes as inputs, data will be transferred to host and then back to
device instead of being used directly.

Result attributes of |sklearnex| classes which contain |sklearn| or |sklearnex| classes may not themselves be
array API compliant. For example, ensemble algorithms contain decision tree estimators result objects which
do not comply with the array API standard.



Example usage
=============
Expand Down
Loading
Loading