test: cleanup outdated checkbox-group focus test #8654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Feb 7, 2025
web-padawan
force-pushed
the
test/cleanup-cbg-test
branch
from
d22c75c to
1d2946f
Compare
|
Chrome test failures look similar to those related to Puppeteer upgrade in #8631. I can't reproduce them locally though. |
web-padawan
force-pushed
the
test/cleanup-cbg-test
branch
from
1d2946f to
8c1bd77
Compare
|
|
This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test was added in the original MVP at vaadin/vaadin-checkbox#103 and its purpose is unclear.
There is no logic related to moving focus in the component nowadays, so it can be removed.
Type of change