fix: stream creation when connections are nil#63
Merged
richard-ramos merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes a race condition in stream creation by ensuring proper nil checks when a connection is closed. The fix addresses a scenario where makeStream could be called on a connection that has been closed but not yet fully cleaned up, preventing potential crashes or undefined behavior.
Changes:
- Set
lsquicConnto nil in connection close callbacks to mark the underlying connection as invalid - Add nil checks in
makeStreamto raiseConnectionClosedErrorwhen attempting to create a stream on a closed connection - Update
makeStreamsignature to properly declare it raisesConnectionClosedError
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lsquic/context/server.nim | Set lsquicConn to nil in server's onConnClosed callback |
| lsquic/context/client.nim | Set lsquicConn to nil in client's onConnClosed callback |
| lsquic/context/context.nim | Add nil checks and error handling in makeStream procedure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladopajic
approved these changes
Feb 17, 2026
gmelodie
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.