Skip to content

fix: stream creation when connections are nil #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richard-ramos merged 1 commit into from
Feb 17, 2026
Merged

fix: stream creation when connections are nil #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lsquic/context/client.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ proc onConnClosed(conn: ptr lsquic_conn_t) {.cdecl.} =
)
quicClientConn.cancelPending()
quicClientConn.onClose()
quicClientConn.lsquicConn = nil
GC_unref(quicClientConn)
lsquic_conn_set_ctx(conn, nil)

Expand Down
7 changes: 6 additions & 1 deletion lsquic/context/context.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,13 @@ method dial*(
): Result[QuicConnection, string] {.base, gcsafe, raises: [].} =
raiseAssert "dial not implemented"

proc makeStream*(ctx: QuicContext, quicConn: QuicConnection) {.raises: [].} =
proc makeStream*(
ctx: QuicContext, quicConn: QuicConnection
) {.raises: [ConnectionClosedError].} =
debug "Creating stream"
if quicConn.isNil or quicConn.lsquicConn.isNil:
debug "Cannot create stream: connection is nil"
raise newException(ConnectionClosedError, "connection closed")
lsquic_conn_make_stream(quicConn.lsquicConn)

proc onNewStream*(
Expand Down
1 change: 1 addition & 0 deletions lsquic/context/server.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ proc onConnClosed(conn: ptr lsquic_conn_t) {.cdecl.} =
if not conn_ctx.isNil:
let quicConn = cast[QuicConnection](conn_ctx)
quicConn.onClose()
quicConn.lsquicConn = nil
GC_unref(quicConn)
lsquic_conn_set_ctx(conn, nil)

Expand Down
Loading