#118 | Use syncHelper to ensure package install complete#119
Closed
LeanderFS wants to merge 2 commits intovaimo:masterfrom
Closed
#118 | Use syncHelper to ensure package install complete#119LeanderFS wants to merge 2 commits intovaimo:masterfrom
LeanderFS wants to merge 2 commits intovaimo:masterfrom
Conversation
LeanderFS
force-pushed
the
bug/118-promises-not-handled-correctly
branch
from
c05f786 to
e1422d7
Compare
Author
|
@jooname Fixed PR conflicts, is it possible you could take a look at this? |
jooname
added a commit
that referenced
this pull request
May 27, 2025
…ng is achieved but without needing to pass Composer instance through different function parameters, should solve #118
Contributor
|
@LeanderFS Very sorry about the delay! I looked into the issue and the solution now in more detail and there are couple of things I'd change. Found it easier to create another pull request to show those: #124 Feel free to comment your thoughts and if you can, please check if those changes work for you! |
Closed
Contributor
|
Closing this in favor of #124 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118