fix: prevent API calls for whitespace-only search input#352
Merged
nilsnolde merged 2 commits intovalhalla:masterfrom Mar 6, 2026
Merged
fix: prevent API calls for whitespace-only search input#352nilsnolde merged 2 commits intovalhalla:masterfrom
nilsnolde merged 2 commits intovalhalla:masterfrom
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/352 |
nilsnolde
approved these changes
Mar 6, 2026
mustaphaturhan
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #347
What's the problem?
You can type just spaces into the waypoint search field and it'll actually make an API call. The API returns a 400 error saying "Nothing to search for", which is correct, but we shouldn't be making that call in the first place.
Why does this happen?
The code checks if the input length is greater than 0 before searching:
But
" ".lengthis 3, not 0, so it passes the check and triggers the API call.The fix
Added
.trim()before checking the length in a few places:Created a
trimmedValuevariable to avoid calling.trim()multiple times:Testing
Note: This PR was created with AI assistance. I discovered the bug through manual testing, and AI helped with debugging. I've reviewed, understood, and verified the fix works as expected.