Skip to content

fix: prevent API calls for whitespace-only search input #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilsnolde merged 2 commits into from
Mar 6, 2026
Merged

fix: prevent API calls for whitespace-only search input #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b346752
fix: prevent API calls for whitespace-only search input
thisisharsh7 Mar 6, 2026
73b21a8
Merge branch 'master' into fix/whitespace-search-validation
nilsnolde Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/components/ui/waypoint-search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,15 @@ export const WaypointSearch = ({
isSuccess,
} = useMutation({
mutationFn: async () => {
const trimmedValue = internalValue.trim();

if (use_geocoding) {
const response = await forward_geocode(internalValue);
const response = await forward_geocode(trimmedValue);
return { type: 'forward' as const, data: response.data };
}

// coordinate parsing
const coords = internalValue.split(/[\s,;]+/);
const coords = trimmedValue.split(/[\s,;]+/);
if (coords.length === 2) {
const lat = coords[1];
const lng = coords[0];
Expand All @@ -82,7 +84,7 @@ export const WaypointSearch = ({
if (result.type === 'coordinates') {
const addresses: ActiveWaypoint[] = [
{
title: internalValue,
title: internalValue.trim(),
description: '',
selected: false,
addresslnglat: result.lngLat,
Expand Down Expand Up @@ -111,7 +113,7 @@ export const WaypointSearch = ({
});

const fetchGeocodeResults = useCallback(() => {
if (internalValue.length === 0) return;
if (internalValue.trim().length === 0) return;
geocodeMutate();
}, [internalValue, geocodeMutate]);

Expand Down Expand Up @@ -157,7 +159,7 @@ export const WaypointSearch = ({
setInternalValue(value);
}}
onKeyDown={(e) => {
if (e.key === 'Enter' && internalValue.length > 0) {
if (e.key === 'Enter' && internalValue.trim().length > 0) {
fetchGeocodeResults();
}
}}
Expand Down