Add proper support for time restrictions which wrap around a day#45
Merged
EightSmart merged 12 commits intodevfrom Sep 2, 2025
Merged
Add proper support for time restrictions which wrap around a day#45EightSmart merged 12 commits intodevfrom
EightSmart merged 12 commits intodevfrom
Conversation
This reverts commit 77b5637.
EightSmart
requested changes
Sep 1, 2025
Member
EightSmart
left a comment
There was a problem hiding this comment.
I would pull out the time range check logic to avoid duplication and make the code neater
bool withinPeriod;
if (startTimeGreater) {
withinPeriod = (tm_gmt->tm_hour >= time["start"].get<int>() ||
tm_gmt->tm_hour <= time["end"].get<int>());
} else {
withinPeriod = (tm_gmt->tm_hour >= time["start"].get<int>() &&
tm_gmt->tm_hour <= time["end"].get<int>());
}
if (withinPeriod) {
// Loop through available levels
}
Member
|
Also you don't need the if statement to assign the previous bool: |
EightSmart
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time restrictions which wrap around a day (e.g. 2300 - 1159z) are presently not implemented correctly, as VFPC would continue to output "OK" for such a restriction even if the current UTC time falls within that range. This PR resolves that issue.