Merged
Conversation
…onfig.json for improved compatibility, and enhance ActionModal with comment annotation handling and programmatic submission. Refine VeltCommentDialogWf with new assignee banner and conditional rendering for resolve buttons. Add new styles for comment dialog UI elements.
…alog components with improved UI elements, and enhance sidebar functionality. Adjust styles for better visibility and usability in comment-related features.
… enhance styles for autocomplete input and comment tool. Improve visibility and usability of UI elements in the comment dialog.
…t tool functionality. Update VeltCommentBubble and VeltCommentTool wireframes for improved comment visibility and interaction. Refactor styles for better UI consistency in comment-related features.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
.../self-hosting/dashboard/postgres/dashboard-postgres-demo/components/document/ActionModal.tsx
Show resolved
Hide resolved
...ting/dashboard/postgres/dashboard-postgres-demo/components/velt/ui-customization/styles.scss
Show resolved
Hide resolved
.../self-hosting/dashboard/postgres/dashboard-postgres-demo/components/document/ActionModal.tsx
Show resolved
Hide resolved
apps/react/self-hosting/forms/page-mode-demo/components/header/header.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if(commentUtils) { | ||
| // @ts-ignore | ||
| commentUtils.on('composerTextChange').subscribe((event: any) => { | ||
| console.log('Text changed:', event); |
There was a problem hiding this comment.
Debug console.log statements left in production code
Low Severity
Two console.log statements appear to be debugging code that was accidentally committed. Line 190 logs every composerTextChange event (which could be very noisy), and line 203 logs the result of addCommentAnnotation. These are typical debugging patterns that are usually removed before committing to production code.
Additional Locations (1)
…nsuring consistent versioning for @veltdev/react and @veltdev/types. Refactor package.json files in various demo applications to reflect the updated dependencies, enhancing compatibility and stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Monorepo Structure Checklist
If adding a new demo, ensure you've followed the 5-level structure:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/package.jsonwith scoped name:@apps/<framework>-<document>-<library-or-solution>-<demo>pnpm --filter <package-name> buildpnpm --filter <package-name> devDeployment Checklist
If this demo should be deployed:
Testing
pnpm -w install && pnpm -w buildDocumentation
master-sample-app(if applicable)Related Issues
Screenshots/Videos
Additional Context
For Reviewers
Demo Location
Path:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/Package name:
@apps/<...>How to Test
Structure Verification
The demo follows the 5-level hierarchy:
Documentation: See README_MONOREPO.md and docs/structure.md for more details on the monorepo structure.
Note
Medium Risk
Broad dependency version bump plus non-trivial changes to comment event handling and programmatic submission flows could introduce behavioral regressions in multiple demo apps, but changes are isolated to sample/demo code.
Overview
Upgrades Velt dependencies across the monorepo demos (React + vanilla CRDT demos) by pinning
@veltdev/react/@veltdev/types/@veltdev/clientto4.7.8, updating rootoverrides,pnpm-lock.yaml, andvelt-versions.jsonaccordingly.Enhances the self-hosting forms page-mode demo to better coordinate inline comment tools with the embedded sidebar: tracks an active tool per question, opens/focuses the page-mode composer on tool clicks, selects threads from bubble clicks, and adds new sidebar options (
defaultMinimalFilter,openAnnotationInFocusMode) plus autocomplete/assign-to configuration and extensive wireframe/CSS refresh (new icons, assignee banner, empty state, tooltips).Updates the self-hosting postgres dashboard demo to support programmatic action-comment submission via
useCommentUtilsby capturing composer text-change annotations, submitting viaaddCommentAnnotation, and clearing the composer; also tweaks a custom dialog to conditionally show resolve UI and adds CSS to hide emptyapp-ifwrappers. Minor tooling tweaks includetsconfigJSX mode change and backend dev script activating a venv.Written by Cursor Bugbot for commit da8efe2. This will update automatically on new commits. Configure here.