-
Notifications
You must be signed in to change notification settings - Fork 0
Mayank/privado wireframes 2 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3bffcd2
Upgrade Velt dependencies to version 4.7.4, update JSX setting in tsc…
mayank-velt bd2a5ff
Update Velt dependencies to version 4.7.8, refine comment tool and di…
mayank-velt b55c7e9
Refactor VeltCommentDialogWf to include tooltip for assign button and…
mayank-velt 3aebac7
Enhance DocumentCanvas and Header components to support active commen…
mayank-velt 3127ba7
save
velt-sdk da8efe2
Update Velt dependencies to version 4.7.8 across multiple packages, e…
velt-sdk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 56 additions & 15 deletions
71
apps/react/self-hosting/forms/page-mode-demo/components/header/header.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...osting/forms/page-mode-demo/components/velt/ui-customization/VeltAutocompleteOptionWf.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| "use client"; | ||
|
|
||
| import { VeltAutocompleteOptionWireframe } from "@veltdev/react"; | ||
| import { CheckIcon } from './VeltIcons'; | ||
|
|
||
| const VeltAutocompleteOptionWf = () => { | ||
| return ( | ||
| <VeltAutocompleteOptionWireframe> | ||
| <div className="privado-autocomplete-option-wrapper"> | ||
| <VeltAutocompleteOptionWireframe.Icon /> | ||
| <VeltAutocompleteOptionWireframe.Name /> | ||
| <CheckIcon /> | ||
| </div> | ||
| </VeltAutocompleteOptionWireframe> | ||
| ); | ||
| }; | ||
|
|
||
| export default VeltAutocompleteOptionWf; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug console.log statements left in production code
Low Severity
Two
console.logstatements appear to be debugging code that was accidentally committed. Line 190 logs everycomposerTextChangeevent (which could be very noisy), and line 203 logs the result ofaddCommentAnnotation. These are typical debugging patterns that are usually removed before committing to production code.Additional Locations (1)
apps/react/self-hosting/dashboard/postgres/dashboard-postgres-demo/components/document/ActionModal.tsx#L202-L203