Handle non image file types in matchesAccept filter #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@obadakhalili is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Great fix, thanks @obadakhalili 🚢 |
| // NOTE: keep simple; expand as needed | ||
| return true; | ||
|
|
||
| const patterns = accept |
Contributor
There was a problem hiding this comment.
🎉 great update - on that note, as AI Elements grows, shall we also include unit tests for such changes?
I haven't had much time in the last few weeks, but would be happy to help on this between the years!
Member
There was a problem hiding this comment.
Definitely, I'll add the unit tests myself but we should start asking for them to be part of the PR 😂
haydenbleasel
added a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming the
acceptprop can take an arbitrary string of types to accept, like:image/*,application/pdf,audio/wav,audio/mpeg,audio/mp3. if this is the case, then the current code won't accept any non-image file types when passing an accept prop that has support for file types besides images because if the code sees a mention ofimage/*, it assumes every file type selected must be an image.