Skip to content

Handle non image file types in matchesAccept filter #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haydenbleasel merged 2 commits into from
Dec 8, 2025
Merged

Handle non image file types in matchesAccept filter #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4703873
handle non image file types in matchesAccept filter
obadakhalili Dec 5, 2025
a7c1a7c
Create small-deer-tan.md
haydenbleasel Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-deer-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ai-elements": patch
---

Handle non image file types in matchesAccept filter
18 changes: 13 additions & 5 deletions packages/elements/src/prompt-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,11 +493,19 @@ export const PromptInput = ({
if (!accept || accept.trim() === "") {
return true;
}
if (accept.includes("image/*")) {
return f.type.startsWith("image/");
}
// NOTE: keep simple; expand as needed
return true;

const patterns = accept
Copy link
Contributor

@tobiasbueschel tobiasbueschel Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great update - on that note, as AI Elements grows, shall we also include unit tests for such changes?

I haven't had much time in the last few weeks, but would be happy to help on this between the years!

Copy link
Member

@haydenbleasel haydenbleasel Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, I'll add the unit tests myself but we should start asking for them to be part of the PR 😂

.split(",")
.map((s) => s.trim())
.filter(Boolean);

return patterns.some((pattern) => {
if (pattern.endsWith("/*")) {
const prefix = pattern.slice(0, -1); // e.g: image/* -> image/
return f.type.startsWith(prefix);
}
return f.type === pattern;
});
},
[accept]
);
Expand Down