fix. date validator will reject 00 in day part.#5907
Open
UndefinedSy wants to merge 1 commit intovesoft-inc:masterfrom
Open
fix. date validator will reject 00 in day part.#5907UndefinedSy wants to merge 1 commit intovesoft-inc:masterfrom
UndefinedSy wants to merge 1 commit intovesoft-inc:masterfrom
Conversation
the `validateDate` impl only checks the overflow of day part,
which allows input like DATE("2024-07-00"). this will lead to
error in the reading process.
a570d34 to
b828172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
validateDateimpl only checks the overflow of day part, which allows input like DATE("2024-07-00"). this will lead to error in reading process.What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
5906
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: