Skip to content

fix. date validator will reject 00 in day part. #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UndefinedSy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix. date validator will reject 00 in day part. #5907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/common/time/TimeUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ class TimeUtils {
if ((p[date.month] - p[date.month - 1]) < date.day) {
return Status::Error("`%s' is not a valid date.", date.toString().c_str());
}
if (UNLIKELY(0 == date.day)) {
return Status::Error("`%s' is not a valid date since invalid day.",
date.toString().c_str());
}
return Status::OK();
}

Expand Down
30 changes: 30 additions & 0 deletions src/common/time/parser/test/DateTimeParserTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,21 @@ TEST(DatetimeReader, DateTimeFailed) {
auto result = parser.readDatetime("1999-01-32T22:22:3.2333");
EXPECT_FALSE(result.ok()) << result.value();
}
{
auto parser = time::DatetimeReader();
auto result = parser.readDatetime("1999-00-03T12:34:56.2333");
EXPECT_FALSE(result.ok()) << result.value();
}
{
auto parser = time::DatetimeReader();
auto result = parser.readDatetime("1999-01-00T22:00:03.2333");
EXPECT_FALSE(result.ok()) << result.value();
}
{
auto parser = time::DatetimeReader();
auto result = parser.readDatetime("1999-00-00T22:22:05.2333");
EXPECT_FALSE(result.ok()) << result.value();
}
}

TEST(DatetimeReader, Date) {
Expand Down Expand Up @@ -278,6 +293,21 @@ TEST(DatetimeReader, DateFailed) {
auto result = parser.readDate("1999-01-32");
EXPECT_FALSE(result.ok()) << result.value();
}
{
auto parser = time::DatetimeReader();
auto result = parser.readDate("1999-00-03");
EXPECT_FALSE(result.ok()) << result.value();
}
{
auto parser = time::DatetimeReader();
auto result = parser.readDate("1999-01-00");
EXPECT_FALSE(result.ok()) << result.value();
}
{
auto parser = time::DatetimeReader();
auto result = parser.readDate("1999-00-00");
EXPECT_FALSE(result.ok()) << result.value();
}
}

TEST(DatetimeReader, Time) {
Expand Down