Tweaked Driver to invoke vSwarm functions#585
Merged
JooyoungPark73 merged 6 commits intomainfrom Feb 10, 2025
Merged
Conversation
aryans1204
force-pushed
the
new-vswarm-deployer
branch
2 times, most recently
from
2e14bcd to
b8ce0d0
Compare
aryans1204
force-pushed
the
new-vswarm-deployer
branch
from
b8ce0d0 to
8aa7e54
Compare
Contributor
leokondrashov
left a comment
leokondrashov
left a comment
There was a problem hiding this comment.
Asking for reviews with failing tests is a bad practice. If you want feedback on why the test fails, please ask directly about that. Otherwise, please fix the test before asking for the review.
JooyoungPark73
requested changes
Feb 3, 2025
pkg/trace/mapper_trace_parser.go
Outdated
| deploymentInfoFile, err := os.ReadFile("deploy_info.json") | ||
| if err != nil { | ||
| wd, _ := os.Getwd() | ||
| deploymentInfoFile, err = os.ReadFile(wd + "/pkg/trace/deploy_info.json") |
Contributor
There was a problem hiding this comment.
Please use p.DirectoryPath and not hardcode dir in the code.
Also return error, not warning, if input file is not detected. It can do nothing if there is no input.
aryans1204
force-pushed
the
new-vswarm-deployer
branch
4 times, most recently
from
39b5e76 to
64ccf99
Compare
JooyoungPark73
previously approved these changes
Feb 6, 2025
JooyoungPark73
force-pushed
the
new-vswarm-deployer
branch
from
8b549f0 to
d531dfc
Compare
JooyoungPark73
previously approved these changes
Feb 10, 2025
Signed-off-by: aryans1204 <arshar1204@gmail.com>
Signed-off-by: aryans1204 <arshar1204@gmail.com>
Signed-off-by: aryans1204 <arshar1204@gmail.com>
Signed-off-by: aryans1204 <arshar1204@gmail.com> Added tests to CI and formatted code Signed-off-by: aryans1204 <arshar1204@gmail.com> Fixing the E2E test for vSwarm loader Signed-off-by: aryans1204 <arshar1204@gmail.com> Extracted vSwarm mock server from standard workload Signed-off-by: aryans1204 <arshar1204@gmail.com>
Signed-off-by: aryans1204 <arshar1204@gmail.com>
Signed-off-by: aryans1204 <arshar1204@gmail.com>
aryans1204
force-pushed
the
new-vswarm-deployer
branch
from
1d50e47 to
603211d
Compare
JooyoungPark73
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small summary of the requirements (in one/two sentences).
Implementation Notes ⚒️
Made changes to
pkg/trace/andpkg/driver/andcmd/loader.goto support execution of vSwarm functions and integrate with downstream vSwarm invoker.External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.