Skip to content

Updating Go version to 1.25.1 in a few more places #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Updating Go version to 1.25.1 in a few more places #5396

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ead041
updating versions
amaschas Oct 22, 2025
cf97661
one more
amaschas Oct 22, 2025
ac12767
updating version
amaschas Oct 22, 2025
a27048e
linter fixes
amaschas Oct 22, 2025
906a40e
reverting linter
amaschas Oct 22, 2025
4bc74bf
reverting
amaschas Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/module_generate/_templates/go/tmpl-go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module {{.ModuleLowercase}}

go 1.23
go 1.25.1
7 changes: 0 additions & 7 deletions etc/.golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@ linters:
- canonicalheader
- containedctx
- contextcheck
- copyloopvar # TODO(go1.23): reenable in follow-up
- cyclop
- depguard
- execinquery
- exhaustruct
- exportloopref
- fatcontext # TODO(go1.23): reenable in follow-up
- forcetypeassert
- funlen
- gocognit
Expand All @@ -33,26 +31,21 @@ linters:
- importas
- inamedparam
- interfacebloat
- intrange # TODO(go1.23): reenable in follow-up
- ireturn
- maintidx
- makezero
- mnd
- musttag
- nakedret
- nestif
- nilnil # TODO(go1.23): low-pri to reenable
- nlreturn
- nonamedreturns
- nosprintfhostport
- paralleltest
- perfsprint
- prealloc
- predeclared # TODO(go1.23): reenable in follow-up
- protogetter # TODO(go1.23): maybe reenable in the future but it's a big diff + buggy.
- spancheck # TODO(go1.23): reenable in follow-up
- tagliatelle
- tenv # TODO(go1.23): reenable in follow-up
- testpackage
- thelper # false positives
- varnamelen
Expand Down
4 changes: 2 additions & 2 deletions etc/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ do_brew(){
tap "viamrobotics/brews"

# pinned
brew "go@1.23", link: true, conflicts_with: ["go"]
brew "go@1.25.3", link: true, conflicts_with: ["go"]
brew "node@18", link: true, conflicts_with: ["node"]

# unpinned
Expand All @@ -177,7 +177,7 @@ do_brew(){
fi

# replace default go with pinned
brew link --overwrite go@1.23
brew link --overwrite go@1.25.3

# due to a missing bottle in homebrew, this has to be installed on its own
brew install upx
Expand Down
Loading