performActionOnBinaryDataFromFilter Parallelism #5439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
vpandiarajan20
commented
Nov 3, 2025
| var wg sync.WaitGroup | ||
|
|
||
| // In one routine, get all IDs matching the filter and pass them into the ids channel. | ||
| wg.Add(1) |
Member
Author
There was a problem hiding this comment.
I also don't think this waitGroup is necessary, but good programming practices maybe?
viambot
added
safe to test
katiepeters
reviewed
Nov 10, 2025
| }() | ||
| }() | ||
| } | ||
| downloadWG.Wait() |
Member
There was a problem hiding this comment.
Should this go after wg.Wait?
| err := actionOnBinaryData(id) | ||
| if err != nil { | ||
| errs <- err | ||
| cancel() |
Member
There was a problem hiding this comment.
Do we want to return here? 🤔
Member
Author
There was a problem hiding this comment.
yes, I think the original code's count was off by one!
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was working on something adjacent and was confused by the additional thread, decided to add a quick fix.
Times for downloading a 3,036 dataset
This isn't definitive proof of a speed up since this is just one trial and I can test more if necessary, but this is also a readability improvement and removes the unprotected
donevariable.Verified appropriate behavior on random error.
Please lmk if the batching was there for a reason that I've overlooked, it doesn't seem to preserve order upon first glance so not sure why it's there.