work around boost/1.88.0 issue on windows #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmorrow
approved these changes
May 29, 2025
Member
acmorrow
left a comment
acmorrow
left a comment
There was a problem hiding this comment.
LGTM, and thanks for fixing.
|
|
||
| def requirements(self): | ||
| self.requires('boost/[>=1.74.0]', transitive_headers=True) | ||
| if self.settings.os == "Windows": |
Member
There was a problem hiding this comment.
Maybe add a TODO: remove windows boost version upper bound once conan resolves XXX (hoping they have a ticket - if not we should open one?).
Collaborator
Author
There was a problem hiding this comment.
good idea and yes they do--conan-io/conan-center-index#27546
stuqdog
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.