Skip to content

work around boost/1.88.0 issue on windows #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

work around boost/1.88.0 issue on windows #443

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7228c74
Update conanfile.py
lia-viam May 28, 2025
53553d5
Update conanfile.py
lia-viam May 29, 2025
50db4b6
doc comment
lia-viam May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ def _grpc_requires(self):
return 'grpc/[>=1.48.4]'

def requirements(self):
self.requires('boost/[>=1.74.0]', transitive_headers=True)
if self.settings.os == "Windows":
Copy link
Member

@acmorrow acmorrow May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a TODO: remove windows boost version upper bound once conan resolves XXX (hoping they have a ticket - if not we should open one?).

Copy link
Collaborator Author

@lia-viam lia-viam May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea and yes they do--conan-io/conan-center-index#27546

self.requires('boost/[>=1.74.0 <1.88.0]', transitive_headers=True)
else:
self.requires('boost/[>=1.74.0]', transitive_headers=True)

# The SDK supports older grpc and protobuf, but these are the oldest
# maintained conan packages.
Expand Down
Loading