RSDK-13626: Remove getImage, Format helpers, and format field usage#149
RSDK-13626: Remove getImage, Format helpers, and format field usage#149
Conversation
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
| val Image.dimensions: ImageDimensions? | ||
| get() = try { | ||
| getDimensions(this.image, this.format.name) | ||
| getDimensions(this.image, this.mimeType) |
There was a problem hiding this comment.
does anything important rely on this? I don't think we should support this anymore
There was a problem hiding this comment.
I'd wait for confirmation from @njooma but I think it's probably fine to get rid of.
There was a problem hiding this comment.
we need to support dimensions i believe for some vision methods that require height/width IIRC
There was a problem hiding this comment.
@hexbabe what're your thoughts on getting rid of it?
Pre-emptive removal ahead of viamrobotics/api#758 which deletes GetImage, RenderFrame, and the Format enum from camera.proto. Removes: - getImage abstract method and mimeToFormat/formatToMime from Camera.java - getImage implementation from CameraRPCClient.java - getImage handler and deleted type imports from CameraRPCService.java - Format import from Media.kt; switches Image.dimensions to use mimeType Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe
force-pushed
the
RSDK-13626-remove-getimage-renderframe
branch
from
2a22c0b to
994e80a
Compare
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
Not approving just to make sure naveed gets a chance to look at the one open question, but lgtm
| val Image.dimensions: ImageDimensions? | ||
| get() = try { | ||
| getDimensions(this.image, this.format.name) | ||
| getDimensions(this.image, this.mimeType) |
There was a problem hiding this comment.
I'd wait for confirmation from @njooma but I think it's probably fine to get rid of.
| val Image.dimensions: ImageDimensions? | ||
| get() = try { | ||
| getDimensions(this.image, this.format.name) | ||
| getDimensions(this.image, this.mimeType) |
There was a problem hiding this comment.
we need to support dimensions i believe for some vision methods that require height/width IIRC
| val Image.dimensions: ImageDimensions? | ||
| get() = try { | ||
| getDimensions(this.image, this.format.name) | ||
| getDimensions(this.image, this.mimeType) |
There was a problem hiding this comment.
@hexbabe what're your thoughts on getting rid of it?
4 participants
Summary
getImageabstract method andmimeToFormat/formatToMimefromCamera.javagetImage()implementation fromCameraRPCClient.javagetImage()handler andGetImageRequest/GetImageResponseimports fromCameraRPCService.javaFormatimport fromMedia.kt; switchImage.dimensionsto usemimeTypeinstead offormat.namePre-emptive cleanup ahead of viamrobotics/api#758 which deletes
GetImage,RenderFrame, and theFormatenum fromcamera.proto. The Java SDK had the deepest usage of these deleted types, including real business logic in the RPC client/service and theMedia.ktutility.Test plan
🤖 Generated with Claude Code