-
Notifications
You must be signed in to change notification settings - Fork 171
Update the RPM URI to refer to GitHub, not RedHat. #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Updates the RPM specification URI to refer to this GitHub repository, rather than RedHat. Signed-off-by: Mr. Beedell, Roke Julian Lockhart (RJLB) <[email protected]>
Summary of ChangesHello @RokeJulianLockhart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the URL in the virtio-win.spec file to point to the project's GitHub repository instead of a generic RedHat URL. This is a good improvement for clarity. I've also suggested adding a BugURL to point to the GitHub issues page, as you mentioned in the description, which would be a helpful addition for users.
| Release: 1 | ||
| Group: Applications/System | ||
| URL: http://www.redhat.com/ | ||
| URL: https://github.com/virtio-win/virtio-win-pkg-scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change to point to the correct project repository. As you mentioned in the PR description, adding a BugURL would indeed be useful. It helps users easily find where to report issues. You can add it right after the URL line to point to the repository's issue tracker.
URL: https://github.com/virtio-win/virtio-win-pkg-scripts
BugURL: https://github.com/virtio-win/virtio-win-pkg-scripts/issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more useful when the domain of each URI differs. I don't see much value in having both when /issues is so trivial to locate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to ignore this comment.
Updates the RPM specification URI to refer to this GitHub repository, rather than RedHat. I don't know whether a “Bug URL” key would also be useful.