Skip to content

Update the RPM URI to refer to GitHub, not RedHat. #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RokeJulianLockhart wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update the RPM URI to refer to GitHub, not RedHat. #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion virtio-win.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Name: virtio-win
Version: 0.1.271
Release: 1
Group: Applications/System
URL: http://www.redhat.com/
URL: https://github.com/virtio-win/virtio-win-pkg-scripts
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good change to point to the correct project repository. As you mentioned in the PR description, adding a BugURL would indeed be useful. It helps users easily find where to report issues. You can add it right after the URL line to point to the repository's issue tracker.

URL: https://github.com/virtio-win/virtio-win-pkg-scripts
BugURL: https://github.com/virtio-win/virtio-win-pkg-scripts/issues

Copy link
Contributor Author

@RokeJulianLockhart RokeJulianLockhart Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more useful when the domain of each URI differs. I don't see much value in having both when /issues is so trivial to locate.

Copy link
Member

@kostyanf14 kostyanf14 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to ignore this comment.

BuildArch: noarch

%if %{rhel_defaults}
Expand Down