-
-
Notifications
You must be signed in to change notification settings - Fork 190
feat(rsc): show logs for build steps #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: hi-ogawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot let's not patch logger. let's start with just log something before each build.
Co-authored-by: hi-ogawa <[email protected]>
Updated to use simple logger.info() calls before each build instead of patching the logger. Commit: 87c4ea4 Build output now shows: [1/5] analyze client references...
vite v7.1.10 building SSR bundle for production...
[2/5] analyze dependencies...
vite v7.1.10 building SSR bundle for production...
[3/5] build rsc...
vite v7.1.10 building SSR bundle for production...
[4/5] build client...
vite v7.1.10 building for production...
[5/5] build ssr...
vite v7.1.10 building SSR bundle for production... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot "analyze dependencies..." should be "analyze server references...".
"build xxx" should be "build xxx environment"
Co-authored-by: hi-ogawa <[email protected]>
Updated the terminology. Commit: 0d31c9f Changes:
Output now shows: [1/5] analyze client references...
[2/5] analyze server references...
[3/5] build rsc environment...
[4/5] build client environment...
[5/5] build ssr environment... |
example
Changes Made
Enhanced build logging in
@vitejs/plugin-rscby adding simple info messages before each build step with improved terminology.Result
Standard build (with SSR):
No-SSR build:
The changes use simple
logger.info()calls before each build to provide clear progress indicators with step numbers and accurate descriptions.Original prompt
Fixes #925
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.