Skip to content

fix: fix hmr of dynamically loaded vue sfc modules in apps with tailwind #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix hmr of dynamically loaded vue sfc modules in apps with tailwind #702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e520c1d
fix: fix hmr of dynamically loaded vue sfc modules in apps with tailwind
unshame Nov 15, 2025
971c15c
fix: filter out non-js modules instead of sorting
unshame Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/plugin-vue/src/handleHotUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,11 @@ function hasScriptChanged(prev: SFCDescriptor, next: SFCDescriptor): boolean {
function getMainModule(modules: ModuleNode[]) {
return (
modules
.filter((m) => !/type=/.test(m.url) || /type=script/.test(m.url))
.filter(
(m) =>
m.type === 'js' &&
(!/type=/.test(m.url) || /type=script/.test(m.url)),
)
// #9341
// We pick the module with the shortest URL in order to pick the module
// with the lowest number of query parameters.
Expand All @@ -343,7 +347,9 @@ function getMainModule(modules: ModuleNode[]) {
}

function getScriptModule(modules: ModuleNode[]) {
return modules.find((m) => /type=script.*&lang\.\w+$/.test(m.url))
return modules.find(
(m) => m.type === 'js' && /type=script.*&lang\.\w+$/.test(m.url),
)
}

export function handleTypeDepChange(
Expand Down
Loading