[release-23.0] Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient (#19085)#19130
Merged
mhamza15 merged 1 commit intorelease-23.0from Jan 12, 2026
Merged
Conversation
Contributor
Author
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
mhamza15
approved these changes
Jan 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-23.0 #19130 +/- ##
================================================
- Coverage 69.71% 69.70% -0.01%
================================================
Files 1606 1606
Lines 214601 214601
================================================
- Hits 149608 149592 -16
- Misses 64993 65009 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…value in `grpctmclient` (vitessio#19085) (vitessio#19130) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…value in `grpctmclient` (vitessio#19085) (vitessio#19130) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…value in `grpctmclient` (vitessio#19085) (vitessio#19130) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…value in `grpctmclient` (vitessio#19085) (vitessio#19130) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #19085