fix(no-alias-methods): Align no-alias-methods rule with Vitest by aliasing toThrow to toThrowError#832
Merged
veritem merged 2 commits intovitest-dev:mainfrom Nov 29, 2025
Merged
Conversation
1 task
xDivisionByZerox
added a commit
to faker-js/faker
that referenced
this pull request
Dec 26, 2025
This commit fixes the autofixable lint errors introduced through the vitest lint plugin update. This mostly reverts the changes introduced in #2098, where .toThrowError was replaced by .toThrow. Apprently, the plugin got it the wrong way around. For more information, look at the fixing PR in their plugin: vitest-dev/eslint-plugin-vitest#832
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vitest docs define toThrow as an alias of toThrowError, so the rule follows the official API.