Skip to content

Revert pull_request_target #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

Revert pull_request_target #225

merged 4 commits into from
Jul 10, 2025

Conversation

sjmonson
Copy link
Collaborator

pull_request_target has not been the drop-in replacement it promises to be. Revert its addition and disable build jobs for external PRs.

@nm-red-hat-upstream-automation-bot NM Red Hat Upstream Automation Bot
Copy link

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16200247289/artifacts/3506036450.
They will be retained for up to 30 days.

@nm-red-hat-upstream-automation-bot NM Red Hat Upstream Automation Bot
Copy link

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16200247281/artifacts/3506036851.
They will be retained for up to 30 days.

@sjmonson sjmonson requested review from DaltheCow, Copilot and markurtz and removed request for DaltheCow July 10, 2025 16:16
Copilot
Copilot AI reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the GitHub Actions workflow from using pull_request_target back to pull_request trigger, addressing issues with the previous implementation. The change disables build jobs for external pull requests to maintain security while allowing other workflow jobs to continue running.

  • Reverts trigger from pull_request_target to pull_request
  • Removes explicit merge commit SHA references from checkout actions
  • Adds conditional execution for build jobs to skip external PRs

@nm-red-hat-upstream-automation-bot NM Red Hat Upstream Automation Bot
Copy link

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16200469700/artifacts/3506128565.
They will be retained for up to 30 days.

@nm-red-hat-upstream-automation-bot NM Red Hat Upstream Automation Bot
Copy link

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16200469470/artifacts/3506128820.
They will be retained for up to 30 days.

@sjmonson sjmonson merged commit 292f073 into main Jul 10, 2025
32 checks passed
@sjmonson sjmonson deleted the fix/pull_request_target branch July 10, 2025 17:07
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
5867f5e 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
Signed-off-by: dalthecow <[email protected]>
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
7dd23a8 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
Signed-off-by: dalthecow <[email protected]>
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
22d33c5 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
88e0200 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
Signed-off-by: dalthecow <[email protected]>
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
b346719 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
8662533 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
Signed-off-by: dalthecow <[email protected]>
DaltheCow pushed a commit that referenced this pull request Jul 15, 2025
@sjmonson @Copilot @DaltheCow
Revert pull_request_target (#225)
8ae87d7 
`pull_request_target` has not been the drop-in replacement it promises
to be. Revert its addition and disable build jobs for external PRs.

---------

Co-authored-by: Copilot <[email protected]>
Signed-off-by: dalthecow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DaltheCow DaltheCow DaltheCow approved these changes

@markurtz markurtz Awaiting requested review from markurtz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjmonson @DaltheCow