Skip to content

Revert pull_request_target #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025
Merged

Revert pull_request_target #225

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c39c4bc
Revert "Fix checkout target for pull request workflows (#212)"
sjmonson Jul 10, 2025
287c559
Revert "Run development workflow from target branch scope (#189)"
sjmonson Jul 10, 2025
270c9a0
Only build if the PR branch is local
sjmonson Jun 17, 2025
0ba22b8
Apply suggestions from code review
sjmonson Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions .github/workflows/development.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Development

on:
pull_request_target:
pull_request:
types: [opened, synchronize, reopened]

jobs:
Expand All @@ -12,8 +12,6 @@ jobs:
python: ["3.9", "3.13"]
steps:
- uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand All @@ -30,8 +28,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"

- name: Install dependencies
run: npm ci
Expand All @@ -46,8 +42,6 @@ jobs:
python: ["3.9", "3.13"]
steps:
- uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand All @@ -64,8 +58,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"

- name: Install dependencies
run: npm ci
Expand All @@ -80,8 +72,6 @@ jobs:
python: ["3.9"]
steps:
- uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand All @@ -98,8 +88,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"

- name: Install dependencies
run: npm ci
Expand All @@ -114,8 +102,6 @@ jobs:
python: ["3.9", "3.13"]
steps:
- uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand All @@ -132,8 +118,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"

- name: Install dependencies
run: npm ci
Expand All @@ -148,8 +132,6 @@ jobs:
python: ["3.9", "3.13"]
steps:
- uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand All @@ -166,8 +148,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v4
with:
ref: "${{ github.event.pull_request.merge_commit_sha }}"

- name: Install dependencies
run: npm ci
Expand All @@ -176,6 +156,8 @@ jobs:
run: npm run test:integration

build:
# Only build if the PR branch is local
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -185,7 +167,6 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: "${{ github.event.pull_request.merge_commit_sha }}"
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand Down Expand Up @@ -228,6 +209,8 @@ jobs:
})

build-and-push-container:
# Only build if the PR branch is local
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
permissions:
packages: write
Expand Down