[docs] mkdocs material is EOL, move to a zensical docs build#2415
[docs] mkdocs material is EOL, move to a zensical docs build#2415dsikka merged 3 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @aireilly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the migration of the project's documentation system from MkDocs to Zensical, a modern successor. The primary goal is to establish Zensical as an alternative build option, allowing for a phased transition given MkDocs' end-of-life status. This involves implementing custom Python scripts to replicate functionalities previously provided by MkDocs plugins, updating build configurations, and ensuring both documentation systems can coexist during the transition period. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the documentation build system from MkDocs to Zensical, which is a necessary move as MkDocs is reaching its end-of-life. The changes introduce Zensical as a parallel build system, keeping the existing MkDocs setup for now. This is a good incremental approach.
Two new Python scripts, gen_api_docs.py and zensical_gen_files.py, have been added to replace functionality from MkDocs plugins that are not compatible with Zensical. My review focuses on these new scripts.
I've identified a couple of high-severity bugs in the find_project_root function in both scripts that could lead to infinite loops or failure to find configuration files in edge cases. I've also provided a medium-severity suggestion to refactor zensical_gen_files.py to improve its maintainability by reducing code duplication.
Overall, this is a solid PR that handles the migration thoughtfully. Addressing the identified issues will make the new build scripts more robust.
1f8ae1d to
8ae1cd9
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
a55592c to
448a638
Compare
fe3537e to
ac12453
Compare
brian-dellabetta
left a comment
There was a problem hiding this comment.
Thanks for updating this! One question, but otherwise things look good
70c08f9 to
15dc8e8
Compare
0b62ee1 to
dedf9e2
Compare
7d8df6f to
4ee7ff4
Compare
Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Remove mkdocs yml and build files Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: Aidan Reilly <aireilly@redhat.com>
Signed-off-by: Aidan Reilly <aireilly@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
d0c6ed8 to
1f0a584
Compare
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
MkDocs is effectively end-of-life. The underlying MkDocs project has been unmaintained since August 2024. Material for MkDocs is now in maintenance mode — critical bugs and security fixes only for 12 months, no new features. Zensical is the explicit successor from the same creator (squidfunk).
zensical is a drop in replacement in the RTD build, no URL changes etc. Peep the PR RTD build, the search is probably the main difference, zensical uses a new custom client-side search.
This PR:
zensical.toml==mkdocs.ymlwith some caveatsapi-autonav,gen-files)mkdocs.ymland all MkDocs dependencies remain untouchedZensical does not support MkDocs plugins. The incompatible plugins are replaced by a build scripts.