feat: standardize editor configs for cross-platform development #442

yuluo-yx · 2025-10-15T14:40:18Z

Fixed [Precommit newline] In the SR project, should all the files end on a new line? #443 dev: standardize editor configs for cross-platform development #441

I referred to some project configurations:

Signed-off-by: yuluo-yx <[email protected]>

netlify · 2025-10-15T14:40:23Z

✅ Deploy Preview for vllm-semantic-router ready!

Name	Link
🔨 Latest commit	`5a9654c`
🔍 Latest deploy log	https://app.netlify.com/projects/vllm-semantic-router/deploys/68f1034c289087000864ae4f
😎 Deploy Preview	https://deploy-preview-442--vllm-semantic-router.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-10-15T14:42:00Z

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 `Root Directory`

Owners: @rootfs, @Xunzhuo
Files changed:

.editorconfig
.gitattributes
.github/workflows/docker-publish.yml
.gitignore
.pre-commit-config.yaml
scripts/quickstart.sh

📁 `config`

Owners: @rootfs
Files changed:

config/tools_db.json

📁 `dashboard`

Owners: @JaredforReal, @Xunzhuo
Files changed:

dashboard/OWNER

📁 `deploy`

Owners: @rootfs, @Xunzhuo
Files changed:

deploy/docker-compose/addons/llm-router-dashboard.json
deploy/kubernetes/istio/tools_db.json
deploy/kubernetes/tools_db.json
deploy/openshift/Dockerfile.llm-katan
deploy/openshift/cleanup-openshift.sh
deploy/openshift/config-openshift.yaml
deploy/openshift/demo/demo-classification-results.json
deploy/openshift/deploy-to-openshift.sh
deploy/openshift/deployment.yaml
deploy/openshift/envoy-openshift.yaml
deploy/openshift/kustomization.yaml
deploy/openshift/openwebui/deploy-openwebui-on-openshift.sh
deploy/openshift/openwebui/deployment.yaml
deploy/openshift/openwebui/kustomization.yaml
deploy/openshift/openwebui/pvc.yaml
deploy/openshift/openwebui/route.yaml
deploy/openshift/openwebui/service.yaml
deploy/openshift/openwebui/uninstall-openwebui.sh
deploy/openshift/template.yaml

📁 `e2e-tests`

Owners: @yossiovadia
Files changed:

e2e-tests/llm-katan/.gitignore
e2e-tests/llm-katan/demo-embed.html
e2e-tests/llm-katan/pyproject.toml
e2e-tests/llm-katan/terminal-demo.html
e2e-tests/start-llm-katan.sh

📁 `src`

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

src/OWNER
src/training/training_lora/OWNER
src/training/training_lora/classifier_model_fine_tuning_lora/go.mod
src/training/training_lora/classifier_model_fine_tuning_lora/train_cpu_optimized.sh
src/training/training_lora/pii_model_fine_tuning_lora/go.mod
src/training/training_lora/pii_model_fine_tuning_lora/train_cpu_optimized.sh
src/training/training_lora/prompt_guard_fine_tuning_lora/go.mod
src/training/training_lora/prompt_guard_fine_tuning_lora/train_cpu_optimized.sh

📁 `tools`

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

tools/linter/go/.golangci.yml
tools/make/milvus.mk
tools/make/openshift.mk
tools/observability/llm-router-dashboard.json

📁 `website`

Owners: @Xunzhuo, @rootfs, @yuluo-yx
Files changed:

website/src/components/ZoomableMermaid/styles.module.css
website/src/pages/community/contributing.tsx

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

rootfs · 2025-10-15T14:43:01Z

@yuluo-yx how to use these files? Can you add these in the contribution guide?

yuluo-yx · 2025-10-16T13:05:38Z

@yuluo-yx how to use these files? Can you add these in the contribution guide?

by install.EditorConfig plugin. for vscode, is EditorConfig for VS Code.

Signed-off-by: yuluo-yx <[email protected]>

yuluo-yx · 2025-10-16T14:20:46Z

.github/workflows/docker-publish.yml

this file change is end of line CRLF -> LF

Signed-off-by: yuluo-yx <[email protected]>

yuluo-yx · 2025-10-16T14:44:43Z

hi @JaredforReal @rootfs

I was able to run precommit locally successfully, but it failed on the CI. What could be the reason for this? 👀

# shown @ 🚀 Everything wins. in ~/workspace/golang/open_source/semantic-router on git:1015-yuluo/chore-dev-config x [22:36:12] 
$ pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for added large files..............................................Passed
go fmt...................................................................Passed
go lint..................................................................Passed
md fmt...................................................................Passed
yaml/yml fmt.............................................................Passed
js/ts lint...............................................................Passed
cargo fmt................................................................Passed
cargo check..............................................................Passed
isort....................................................................Passed
black....................................................................Passed
(.venv)

rootfs · 2025-10-16T14:47:26Z

@yuluo-yx some files need to be updated

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted bench/vllm_semantic_router_bench/dataset_implementations/__init__.py
reformatted bench/vllm_semantic_router_bench/dataset_factory.py
reformatted src/training/classifier_model_fine_tuning/ft_linear.py
reformatted src/training/training_lora/classifier_model_fine_tuning_lora/ft_qwen3_generative_lora.py
reformatted src/training/training_lora/classifier_model_fine_tuning_lora/ft_linear_lora.py
reformatted src/training/training_lora/prompt_guard_fine_tuning_lora/jailbreak_bert_finetuning_lora.py
reformatted src/training/pii_model_fine_tuning/pii_bert_finetuning.py
reformatted src/training/training_lora/pii_model_fine_tuning_lora/pii_bert_finetuning_lora.py
reformatted src/training/prompt_guard_fine_tuning/jailbreak_bert_finetuning.py

yuluo-yx · 2025-10-16T14:52:08Z

@yuluo-yx some files need to be updated

yep, but run pre-commit run --all-files, then git status, no changes, Was it me who executed the wrong command? 🤔

JaredforReal · 2025-10-16T14:56:47Z

Maybe just revert the mentioned files below, and git commit them without running pre-commit run --all-files, it should be an issue related to the conflict between isort and black.

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted bench/vllm_semantic_router_bench/dataset_implementations/__init__.py
reformatted bench/vllm_semantic_router_bench/dataset_factory.py
reformatted src/training/classifier_model_fine_tuning/ft_linear.py
reformatted src/training/training_lora/classifier_model_fine_tuning_lora/ft_qwen3_generative_lora.py
reformatted src/training/training_lora/classifier_model_fine_tuning_lora/ft_linear_lora.py
reformatted src/training/training_lora/prompt_guard_fine_tuning_lora/jailbreak_bert_finetuning_lora.py
reformatted src/training/pii_model_fine_tuning/pii_bert_finetuning.py
reformatted src/training/training_lora/pii_model_fine_tuning_lora/pii_bert_finetuning_lora.py
reformatted src/training/prompt_guard_fine_tuning/jailbreak_bert_finetuning.py

yuluo-yx · 2025-10-16T15:00:43Z

@JaredforReal emmm～ my pr not hava any py file 😂

yuluo-yx · 2025-10-16T15:40:28Z

by #456

feat: standardize editor configs for cross-platform development

33e165b

Signed-off-by: yuluo-yx <[email protected]>

yuluo-yx requested review from Xunzhuo and rootfs as code owners October 15, 2025 14:40

github-actions bot assigned rootfs and Xunzhuo Oct 15, 2025

Merge branch 'main' into 1015-yuluo/chore-dev-config

c62ca89

docs: add docs

0fed3ca

Signed-off-by: yuluo-yx <[email protected]>

github-actions bot assigned yuluo-yx Oct 16, 2025

chore

18e77e6

Signed-off-by: yuluo-yx <[email protected]>

rootfs previously approved these changes Oct 16, 2025

View reviewed changes

update

95af765

Signed-off-by: yuluo-yx <[email protected]>

yuluo-yx dismissed rootfs’s stale review via 95af765 October 16, 2025 14:13

yuluo-yx added 2 commits October 16, 2025 22:16

update

3a06a56

Signed-off-by: yuluo-yx <[email protected]>

chore: add new line

6ec731c

Signed-off-by: yuluo-yx <[email protected]>

yuluo-yx requested a review from wangchen615 as a code owner October 16, 2025 14:19

github-actions bot assigned JaredforReal, wangchen615 and yossiovadia Oct 16, 2025

Merge branch 'main' into 1015-yuluo/chore-dev-config

26f8719

yuluo-yx commented Oct 16, 2025

View reviewed changes

.github/workflows/docker-publish.yml

Copy link

Contributor Author

yuluo-yx Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file change is end of line CRLF -> LF

fix ci

5a9654c

Signed-off-by: yuluo-yx <[email protected]>

yuluo-yx mentioned this pull request Oct 16, 2025

[Precommit newline] In the SR project, should all the files end on a new line? #443

Closed

yuluo-yx closed this Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: standardize editor configs for cross-platform development #442

feat: standardize editor configs for cross-platform development #442

Uh oh!

yuluo-yx commented Oct 15, 2025 •

edited

Loading

Uh oh!

netlify bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

rootfs commented Oct 15, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

yuluo-yx Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

rootfs commented Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

JaredforReal commented Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: standardize editor configs for cross-platform development #442

feat: standardize editor configs for cross-platform development #442

Uh oh!

Conversation

yuluo-yx commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vllm-semantic-router ready!

Uh oh!

github-actions bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👥 vLLM Semantic Team Notification

📁 Root Directory

📁 config

📁 dashboard

📁 deploy

📁 e2e-tests

📁 src

📁 tools

📁 website

🎉 Thanks for your contributions!

Uh oh!

rootfs commented Oct 15, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

yuluo-yx Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

rootfs commented Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

JaredforReal commented Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

yuluo-yx commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yuluo-yx commented Oct 15, 2025 •

edited

Loading

netlify bot commented Oct 15, 2025 •

edited

Loading

github-actions bot commented Oct 15, 2025 •

edited

Loading

📁 `Root Directory`

📁 `config`

📁 `dashboard`

📁 `deploy`

📁 `e2e-tests`

📁 `src`

📁 `tools`

📁 `website`