-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[CI/Build] Fix param mismatch in test_eagle_correctness
#22847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Fix param mismatch in test_eagle_correctness
#22847
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a parameter mismatch in the test_eagle_correctness
test. A previous change had commented out a test case parameter but neglected to remove its corresponding ID, leading to a test failure. This PR resolves the issue by commenting out the associated test ID, ensuring the test configuration is valid. The change is straightforward and correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
OK I found a failure in
|
…ct#22847) Signed-off-by: DarkLight1337 <[email protected]>
…ct#22847) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
#22611 forgot to remove the corresponding param inside
ids
.I'll force-merge this once approved since I can run these tests locally now
Test Plan
Test Result
(Optional) Documentation Update