-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[DP] support torchrun external launcher with Data Parallelism #24899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f09d97 to
521eeab
Compare
zhuohan123
reviewed
Sep 15, 2025
|
This pull request has merge conflicts that must be resolved before it can be |
569485c to
43fd309
Compare
zou3519
approved these changes
Sep 18, 2025
BoyuanFeng
reviewed
Sep 18, 2025
BoyuanFeng
approved these changes
Sep 18, 2025
43fd309 to
56f3d37
Compare
56f3d37 to
33881ce
Compare
…rank Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Lu Fang <[email protected]>
93aca33 to
04a487d
Compare
Member
|
Will force merge since the CI failure is not caused by this PR and is being fixed by #25396 |
|
This pull request has been imported. If you are a Meta employee, you can view this in D82998295. |
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]> Signed-off-by: charlifu <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]> Signed-off-by: yewentao256 <[email protected]>
gjc0824
pushed a commit
to gjc0824/vllm
that referenced
this pull request
Oct 10, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]> Signed-off-by: gaojc <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]>
1 task
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…roject#24899) Signed-off-by: Lu Fang <[email protected]> Signed-off-by: Zhuohan Li <[email protected]> Co-authored-by: Zhuohan Li <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/build
documentation
Improvements or additions to documentation
ready
ONLY add when PR is ready to merge/full CI is needed
v1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan/Results
Simple Example
lm_eval
Need patch lm_eval PR EleutherAI/lm-evaluation-harness#3304
baseline of non torchrun version
Added CI tests
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.