Fix captions menu not closing on mouseleave in mediaelement player#887
Open
tobias-franke wants to merge 1 commit intovoc:mainfrom
Open
Fix captions menu not closing on mouseleave in mediaelement player#887tobias-franke wants to merge 1 commit intovoc:mainfrom
tobias-franke wants to merge 1 commit intovoc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced while addressing Issue #881 (captions not selectable on touch devices).
The Situation
To fix the issue where mobile users could not select subtitles, a
setTimeoutwas added tovendor/assets/javascripts/mediaelement-and-player.js. The intention was to delay the hiding of the menu slightly, giving touch devices enough time to register a click on the menu items before focus was lost.The Problem
The implementation of this delay introduced a bug. The
setTimeoutwas placed outside the event handler causing themouseleaveandfocusoutevent listeners never getting attached. This had the effect, that the the captions menu would stay visible permanently.How to reproduce
The Fix
I have moved the
setTimeoutinside the event handler callback.addEventListeneris called immediately, so themouseleavelistener is correctly attached, and the menu closes as expected.Validation
I tested the changes with a local dev setup on both a desktop and a mobile browser.