Skip to content

Fix captions menu not closing on mouseleave in mediaelement player #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobias-franke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix captions menu not closing on mouseleave in mediaelement player #887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions vendor/assets/javascripts/mediaelement-and-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2338,12 +2338,13 @@ Object.assign(_player2.default.prototype, {
}

for (var _i4 = 0, _total2 = outEvents.length; _i4 < _total2; _i4++) {
// add a small timeout so mobile devices can activate the buttons before focus is lost
setTimeout(function () {
player.captionsButton.addEventListener(outEvents[_i4], function () {
(0, _dom.addClass)(this.querySelector('.' + t.options.classPrefix + 'captions-selector'), t.options.classPrefix + 'offscreen');
});
}, 20);
player.captionsButton.addEventListener(outEvents[_i4], function () {
var self = this;
// add a small timeout so mobile devices can activate the buttons before focus is lost
setTimeout(function () {
(0, _dom.addClass)(self.querySelector('.' + t.options.classPrefix + 'captions-selector'), t.options.classPrefix + 'offscreen');
}, 20);
});
}

for (var _i5 = 0, _total3 = captions.length; _i5 < _total3; _i5++) {
Expand Down Expand Up @@ -2379,9 +2380,10 @@ Object.assign(_player2.default.prototype, {

for (var _i8 = 0, _total6 = outEvents.length; _i8 < _total6; _i8++) {
player.chaptersButton.addEventListener(outEvents[_i8], function () {
var self = this;
// add a small timeout so mobile devices can activate the buttons before focus is lost
setTimeout(function () {
(0, _dom.addClass)(this.querySelector('.' + t.options.classPrefix + 'chapters-selector'), t.options.classPrefix + 'offscreen');
(0, _dom.addClass)(self.querySelector('.' + t.options.classPrefix + 'chapters-selector'), t.options.classPrefix + 'offscreen');
}, 20);
});
}
Expand Down