Don't delete files that are still accessible from the cache#1751
Closed
Don't delete files that are still accessible from the cache#1751
Conversation
Member
Author
|
So we need to make sure the cache is filtered down to just file in the symbols path (or remote). |
Member
Author
|
This didn't rebase well. Rewritten at #1927. Closing this off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a naive means to ensure we never delete files that are still valid/exist from the cache. The downside with this is that even if a file isn't in the user's symbols path, it might still be retrieved and used (which would be confusing, so the PR can't be committed in its current form). We'd probably need to filter the returned list of symbols to make sure they're remote or that they're in the user's current symbol directory...
Closes #1255