Only act on local cache symbols under the symbol basepaths#1927
Merged
Only act on local cache symbols under the symbol basepaths#1927
Conversation
Member
Author
|
Supercedes #1751 |
ikelos
commented
Jan 8, 2026
| if local_filepath and local_filepath.startswith( | ||
| tuple(constants.SYMBOL_BASEPATHS) | ||
| ): | ||
| yield row["location"] |
Member
Author
There was a problem hiding this comment.
Needs an else with a debug message saying it was found but outside the appropriate path.
Member
Author
|
This is problematic because some local JSON files (such as those under the volatility directory) want to be loaded even though they're not under the symbol directories... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1255