feat: removal of unavailable peers #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volodymyrprokopyuk Do you think it's worth to merge? |
|
Hi, @mimol91! Grate work! I've added some comments to your code. Once resolved the above comments, I'll merge you work! Thank you! |
|
@volodymyrprokopyuk Thanks for the project. It teaches how blockchain works in really nice way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any of the registered peers is unavailable remove it from the list
Related to: #3
Peers registration / removal is not concurrent safe - I've kept it as it is to do not overcomplicate it
I've decreased peer discovery interval in test - as sometimes peerdiscovery test were not passed. (It can be solved with upcoming synctest in go 1.25)