duckdb: switch to v2 extension for clickbench benchmark #3585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
from
b4b51dd to
0fbfd22
Compare
0ax1
commented
Jun 20, 2025
| enum EngineCtx { | ||
| DataFusion(DataFusionCtx), | ||
| DuckDB(DuckDBCtx), | ||
| DuckDB(ddb2::DuckDBCtx), |
Contributor
Author
There was a problem hiding this comment.
The 2 suffix will go away once TPC-H is moved over too.
Contributor
There was a problem hiding this comment.
dont forget tpc-ds 🙈
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
2 times, most recently
from
e61d455 to
6edd161
Compare
| EngineCtx::DuckDB(DuckDBCtx { | ||
| duckdb_path: duckdb_path.to_path_buf(), | ||
| }) | ||
| fn new_with_duckdb() -> anyhow::Result<Self> { |
joseph-isaacs
approved these changes
Jun 20, 2025
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
from
8a4bc6c to
17a5603
Compare
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
2 times, most recently
from
d83f2d2 to
f9f60cd
Compare
Contributor
Benchmarks: TPC-H on NVMETable of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
from
d7e1d08 to
08351cd
Compare
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
from
7f9fa78 to
247ca13
Compare
Signed-off-by: Alexander Droste <[email protected]>
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
from
247ca13 to
d9b7c16
Compare
Contributor
Benchmarks: TPC-H on S3Table of Results
|
Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
0ax1
force-pushed
the
ad/wire-up-ddb-clickbench
branch
from
ec731d4 to
08d4cc0
Compare
Contributor
Author
|
Some of the benchmarks for |
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
…3585) Signed-off-by: Alexander Droste <[email protected]> Signed-off-by: mwlon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.