fix: make dylib rpath available for all targets #3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Droste <[email protected]>
0ax1
commented
Jun 21, 2025
| shell: bash | ||
| env: | ||
| RUST_BACKTRACE: full | ||
| LD_LIBRARY_PATH: target/duckdb-v1.3.0 |
Contributor
Author
There was a problem hiding this comment.
Setting this env var is not required locally. It's not clear to me yet why this is necessay on CI. The current setup otherwise works locally on macOS and Linux (Docker container).
Contributor
Author
There was a problem hiding this comment.
I did a CI run, running ls as part of a build task to check whether the current working dir and duckdb dylib location is correct, which was the case.
0ax1
commented
Jun 21, 2025
| // Link against DuckDB dylib. | ||
| println!("cargo:rustc-link-search=native={}", lib_path.display()); | ||
| println!("cargo:rustc-link-lib=dylib=duckdb"); | ||
| println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_path.display()); |
Contributor
Author
There was a problem hiding this comment.
vortex-duckdb-ext also sets the rpath value in order to be self-contained in terms of linker flags. Ideally, this rpath value would propagate to other crates linking against vortex-duckdb-ext which is not the case though.
Contributor
Contributor
Benchmarks: TPC-H on NVMETable of Results
|
Contributor
Benchmarks: TPC-H on S3Table of Results
|
Contributor
Benchmarks: compressTable of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
The dynamic library search path is defined relative to the executable location. Executables either reside under `target/<build_config>` or `target/<build_config>/deps`. Signed-off-by: Alexander Droste <[email protected]> Signed-off-by: mwlon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic library search path is defined relative to the executable location. Executables either reside under
target/<build_config>ortarget/<build_config>/deps.