Skip to content

fix: make dylib rpath available for all targets #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0ax1 merged 1 commit into from
Jun 21, 2025
Merged

fix: make dylib rpath available for all targets #3590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ rustflags = [
"-C", "force-frame-pointers=yes",
# Add dynamic DuckDB library directory to runtime search path.
"-C", "link-arg=-Wl,-rpath,$ORIGIN/../duckdb-v1.3.0",
"-C", "link-arg=-Wl,-rpath,@executable_path/../duckdb-v1.3.0"
"-C", "link-arg=-Wl,-rpath,$ORIGIN/../../duckdb-v1.3.0",
"-C", "link-arg=-Wl,-rpath,@executable_path/../duckdb-v1.3.0",
"-C", "link-arg=-Wl,-rpath,@executable_path/../../duckdb-v1.3.0"
]

[target.wasm32-unknown-unknown]
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/bench-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ jobs:

- name: Run ${{ matrix.benchmark.name }} benchmark
shell: bash
env:
RUST_BACKTRACE: full
LD_LIBRARY_PATH: target/duckdb-v1.3.0
Copy link
Contributor Author

@0ax1 0ax1 Jun 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this env var is not required locally. It's not clear to me yet why this is necessay on CI. The current setup otherwise works locally on macOS and Linux (Docker container).

Copy link
Contributor Author

@0ax1 0ax1 Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a CI run, running ls as part of a build task to check whether the current working dir and duckdb dylib location is correct, which was the case.

run: |
target/release_debug/${{ matrix.benchmark.id }} -d gh-json | tee ${{ matrix.benchmark.id }}.json

Expand Down
1 change: 1 addition & 0 deletions vortex-duckdb-ext/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ fn main() {
// Link against DuckDB dylib.
println!("cargo:rustc-link-search=native={}", lib_path.display());
println!("cargo:rustc-link-lib=dylib=duckdb");
println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_path.display());
Copy link
Contributor Author

@0ax1 0ax1 Jun 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vortex-duckdb-ext also sets the rpath value in order to be self-contained in terms of linker flags. Ideally, this rpath value would propagate to other crates linking against vortex-duckdb-ext which is not the case though.


if env::var("TARGET").unwrap().contains("linux") {
println!("cargo:rustc-link-lib=stdc++");
Expand Down
Loading