Skip to content

fix: make StructReader lazy #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a10y wants to merge 2 commits into
base: develop
Choose a base branch
from

add tests

7740da2
Select commit
Loading
Failed to load commit list.
Open

fix: make StructReader lazy #6143

add tests
7740da2
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Jan 26, 2026 in 0s

Performance Regression: -19.65%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 12 improved benchmarks
❌ 7 regressed benchmarks
✅ 1246 untouched benchmarks
⏩ 1294 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime u8_FoR[10M] 8 µs 6.8 µs +18.72%
⚡ WallTime u64_values_u8_codes[10M] 260.3 µs 221.5 µs +17.52%
⚡ Simulation canonical_into_non_nullable[(10000, 1, 0.01)] 41.1 µs 32.3 µs +27.31%
⚡ Simulation canonical_into_non_nullable[(10000, 1, 0.0)] 36.2 µs 25.8 µs +40.31%
⚡ Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 278.9 µs 195.6 µs +42.57%
⚡ Simulation canonical_into_non_nullable[(10000, 1, 0.1)] 57 µs 48.1 µs +18.63%
⚡ Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 471.6 µs 382.2 µs +23.4%
⚡ Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 306 µs 222.7 µs +37.45%
❌ Simulation into_canonical_non_nullable[(10000, 1, 0.01)] 39.2 µs 47.1 µs -16.92%
❌ Simulation into_canonical_non_nullable[(10000, 1, 0.0)] 33 µs 41.1 µs -19.65%
⚡ Simulation into_canonical_non_nullable[(10000, 10, 0.0)] 283.5 µs 200.2 µs +41.58%
❌ Simulation into_canonical_non_nullable[(10000, 1, 0.1)] 55.3 µs 63.7 µs -13.17%
⚡ Simulation into_canonical_non_nullable[(10000, 10, 0.1)] 472.8 µs 383.7 µs +23.24%
⚡ Simulation into_canonical_non_nullable[(10000, 10, 0.01)] 310.4 µs 227.8 µs +36.24%
❌ Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.3 ms 4.9 ms -12.51%
⚡ Simulation into_canonical_nullable[(10000, 10, 0.1)] 716.9 µs 627.6 µs +14.23%
❌ Simulation into_canonical_nullable[(10000, 10, 0.0)] 456 µs 536.8 µs -15.06%
❌ Simulation into_canonical_nullable[(10000, 100, 0.0)] 4.3 ms 5 ms -14.39%
❌ Simulation into_canonical_nullable[(10000, 100, 0.1)] 6.1 ms 6.9 ms -11.97%

Comparing aduffy/lazy-project (7740da2) with develop (a66a58d)

Open in CodSpeed

Footnotes

  1. 1294 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ