Skip to content

Conversation

@Andeshog
Copy link
Contributor

@Andeshog Andeshog commented Nov 3, 2025

  • Added overload of the ssa function which takes containers (std::vector, Eigen::VectorXd etc) as the parameter
  • Added method in the Eta struct which applies ssa to the angles

@Andeshog Andeshog linked an issue Nov 3, 2025 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.86%. Comparing base (152f8a2) to head (2acb444).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
include/vortex/utils/math.hpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   98.10%   97.86%   -0.25%     
==========================================
  Files           3        4       +1     
  Lines         369      374       +5     
  Branches       70       72       +2     
==========================================
+ Hits          362      366       +4     
  Misses          4        4              
- Partials        3        4       +1     
Flag Coverage Δ
unittests 97.86% <83.33%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/vortex/utils/types.hpp 95.58% <ø> (ø)
src/math.cpp 95.06% <100.00%> (ø)
include/vortex/utils/math.hpp 80.00% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jorgenfj jorgenfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Andeshog Andeshog merged commit c409297 into main Nov 4, 2025
5 checks passed
@Andeshog Andeshog deleted the feat/ssa-overloads branch November 4, 2025 14:13
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Overload ssa method

3 participants