Merged
Conversation
bastelfreak
force-pushed
the
openvox
branch
9 times, most recently
from
8f9effb to
edef06f
Compare
bastelfreak
force-pushed
the
openvox
branch
3 times, most recently
from
4543370 to
e33d800
Compare
bastelfreak
added
backwards-incompatible
and removed
enhancement
Member
Author
|
This should be just an enhancement. But we did a major release for puppet_metadata as well, it makes sense to be consistent here. |
TheMeier
approved these changes
Mar 18, 2025
ekohl
reviewed
Mar 18, 2025
ekohl
approved these changes
Mar 18, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'm not sure this needs to be a major version. We only add support for an additional collection.
On the other hand, we know that Puppet's nightly collection is busted anyway because it's no longer getting updated (since October). We don't have openvox nightly packages. Perhaps that's a good excuse to simplify the code first by dropping nightly.
In short, I think the current PR is ready to be merged as an enhancement but would also be open to a backwards incompatible change to drop nightly.
bastelfreak
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the following changes were required:
Tested at: voxpupuli/puppet-example#87