Fixed logic for single node gluster servers #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @glorpen, thanks for the PR. Can you please rebase against our latest master branch? |
When having multiple interfaces on a gluster cluster. It is now possible to probe each interface and facter will return the other names as well. Otherwise fater will probe each run Fixes voxpupuli#124
Fixed rubocop offenses. Added peer test for case hostname != fqdn. Added test for volume creation exec when there is only one node.
Contributor
Author
|
@bastelfreak done |
Contributor
Author
|
@bastelfreak ping |
Member
|
Thanks for the fix @glorpen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to configure Gluster on single node no
gluster::volumeexec's were applied, no volume created, etc.This behavior was created by assumptions on
gluster_peer_countandgluster_peer_listfacts as it is empty when operating on single node.Second thing was that check for missing bricks (in
gluster::volume) always failed because of emptygluster_peer_list- no peers, no volumes :). Fortunately there already was #125 which seemed as good fit. Since it worked, It's now merged into this PR.Fixes #6 , but since that time behaviour has changed a little - no duplicates, just nothing :).