Handle noarch artifacts #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages like openvox-server, openvoxdb and openvoxdb-termini are noarch and need a different naming schem when constructing urls to fetch them from the artifacts server. * adds a noarch_package() test to common.sh * adds a set_package_architecture() function to common.sh * extracts set_architecture() from install_build_artifact_linux.sh into common.sh and renames as set_cpu_architecture() * extracts set_package_url() from install_build_artifact_linux.sh into common.sh and renames as set_artifacts_package_url() * modifies set_artifacts_package_url() to set_package_architecture() so we get correct urls for noarch and arch packages * adds tests to the bash specs for all the above
jpartlow
force-pushed
the
handle-noarch-artifacts
branch
9 times, most recently
from
c2e6c94 to
25afac6
Compare
jpartlow
force-pushed
the
handle-noarch-artifacts
branch
2 times, most recently
from
b30ee61 to
2fed36f
Compare
The kvm_automation_tooling generated inventory files rely on a fork of the puppetlabs-terraform module plugins to extract target information from the Terraform state file (jpartlow/puppetlabs-terraform@include-module-when-resolving-references). This change came between v1 and v2 kvm_automation_tooling versions. When we run openvox_bootstrap tasks, in CI, the Bolt installation only has the base puppetlabs-terraform module to work with, so we need an inventory file with explicit target information (ip addresses) now that nested_vms is using kvm_automation_tooling@v2. The .inventory.targets from 'bolt inventory show --format json' is suitable as a concrete list of targets with a little massaging (there is a 'groups' entry that Bolt doesn't expect in an inventory file).
The pr_testing_with_nested_vms workflow was passing for Fedora 42 as of 2025-06-27, but stopped some time after. From the last successful log, systemd was being installed as a transitive dependency of wget, but that is no longer the case.
jpartlow
force-pushed
the
handle-noarch-artifacts
branch
2 times, most recently
from
91da2f8 to
f28f1c5
Compare
There's a peculiarity in openvoxdb-termini pathing on the artifacts server (it's in the openvoxdb directory rather than its own openvoxdb-termini directory) so I've special cased the pathing in set_artifacts_package_url() for that case and am expanding the coverage to include openvoxdb and openvoxdb-termini to expose the issue and provide validation that these packages can also be obtained from artifacts.
jpartlow
force-pushed
the
handle-noarch-artifacts
branch
from
f28f1c5 to
ba61717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Packages like openvox-server, openvoxdb and openvoxdb-termini are noarch
and need a different naming schem when constructing urls to fetch them
from the artifacts server.
common.sh and renames as set_cpu_architecture()
common.sh and renames as set_artifacts_package_url()
we get correct urls for noarch and arch packages
This Pull Request (PR) fixes the following issues
n/a