Skip to content

Add GB size unit support#231

Merged
smortex merged 2 commits intovoxpupuli:masterfrom
artonix101:add-gb-to-size-units
Dec 16, 2025
Merged

Add GB size unit support#231
smortex merged 2 commits intovoxpupuli:masterfrom
artonix101:add-gb-to-size-units

Conversation

@artonix101
Copy link
Copy Markdown
Contributor

Pull Request (PR) description

This PR adds support for GB as a unit for the cache_mem parameter (see issue #229). Corresponding tests have been added to verify the new functionality.

This Pull Request (PR) fixes the following issues

Fixes #229

- Add GB to size unit parsing
- Add tests for GB size units
@smortex
Copy link
Copy Markdown
Member

smortex commented Dec 16, 2025

REFERENCE.md is outdated

Please update REFERENCE.md with

$ bundle exec rake strings:generate:reference

Add it to your branch, push to update the PR and CI should pass.

@artonix101
Copy link
Copy Markdown
Contributor Author

Thank you for the tip, the CI has passed.

Copy link
Copy Markdown
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@smortex smortex merged commit eb609bb into voxpupuli:master Dec 16, 2025
15 checks passed
@artonix101 artonix101 deleted the add-gb-to-size-units branch December 17, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accepted size units (GB missing)

2 participants