Skip to content

Add GB size unit support #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smortex merged 2 commits into from
Dec 16, 2025
Merged

Add GB size unit support #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d981ac
Add GB size unit support
artonix101 Dec 16, 2025
327134d
add gb support for _cache_mem_ and regenerate REFERENCE.md
artonix101 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ By setting optional `ssl` parameter to `true` will create https_port entries ins

* [`Squid::Action::SslBump`](#Squid--Action--SslBump): Possible SSLBump options
* [`Squid::PkgEnsure`](#Squid--PkgEnsure): Custom type representing package status and/or version
* [`Squid::Size`](#Squid--Size): Custom type containing the numeral value and the unit of messurement (Kilo- or Megabyte)
* [`Squid::Size`](#Squid--Size): Custom type containing the numeral value and the unit of messurement (Kilo-, Mega-, or Gigabyte)

## Classes

Expand Down Expand Up @@ -1717,7 +1717,7 @@ Alias of `Variant[Pattern[/^\d.*/], Enum['present', 'latest', 'absent', 'purged'

### <a name="Squid--Size"></a>`Squid::Size`

Custom type containing the numeral value and the unit of messurement (Kilo- or Megabyte)
Custom type containing the numeral value and the unit of messurement (Kilo-, Mega-, or Gigabyte)

Alias of `Pattern[/^\d+ [KM]B$/]`
Alias of `Pattern[/^\d+ [KMG]B$/]`

3 changes: 3 additions & 0 deletions spec/type_aliases/squid_size_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,14 @@
it { is_expected.to allow_value('1 MB') }
it { is_expected.to allow_value('10 KB') }
it { is_expected.to allow_value('9876543210 KB') }
it { is_expected.to allow_value('1 GB') }
it { is_expected.not_to allow_value('-1 KB') }
it { is_expected.not_to allow_value('1 kB') }
it { is_expected.not_to allow_value('1 Kb') }
it { is_expected.not_to allow_value('1 Mb') }
it { is_expected.not_to allow_value('1 KBB') }
it { is_expected.not_to allow_value('a KBB') }
it { is_expected.not_to allow_value('1KB') }
it { is_expected.not_to allow_value('1 gb') }
it { is_expected.not_to allow_value('1 Gb') }
end
4 changes: 2 additions & 2 deletions types/size.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# @summary
# Custom type containing the numeral value and the unit of messurement (Kilo- or Megabyte)
type Squid::Size = Pattern[/^\d+ [KM]B$/]
# Custom type containing the numeral value and the unit of messurement (Kilo-, Mega-, or Gigabyte)
type Squid::Size = Pattern[/^\d+ [KMG]B$/]